Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supporting virtual element via FloatingUI #228

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

SerhiiTsybulskyi
Copy link
Contributor

@SerhiiTsybulskyi SerhiiTsybulskyi commented Jun 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Chart tooltip wrong position

Issue Number: N/A

What is the new behavior?

Add supporting virtual elements to show chart tooltip which not following by cursor

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screenshot 2024-06-12 at 15 54 48

@SerhiiTsybulskyi SerhiiTsybulskyi requested a review from amcdnl June 12, 2024 12:57
@SerhiiTsybulskyi SerhiiTsybulskyi self-assigned this Jun 12, 2024
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reablocks-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 0:57am

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 6d5003e
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/66699b1f7be2760008f11178
😎 Deploy Preview https://deploy-preview-228--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit 6856672 into master Jun 12, 2024
7 checks passed
@amcdnl amcdnl deleted the floating-ui-virtual-el branch June 12, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants