-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align and update tokens with Figma component library #232
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for reablocks-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@amcdnl after seeing some of the changes that Kyle is working on, I think it might be a good idea to try and take into account the changes that he's proposing before merging this. |
@@ -61,7 +61,7 @@ export const ForgotPassword = () => { | |||
<h4 className="text-2xl font-sans font-bold mb-0"> | |||
Reset your password | |||
</h4> | |||
<span className="text-base text-panel-secondary-content font-sans"> | |||
<span className="text-base text-text-secondary font-sans"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text-text-secondary
- Not in love w/ that.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Move
panel.content
,panel.secondary-content
andsurface.content
tokens into atext
block and renaming tocontent-primary
andcontent-secondary
Theme files where
*-panel-content
,*-panel-secondary-content
and*-surface-content
are being used have been updated to*-content-primary
and*-content-secondary
. If existing applicationspanel.content
andsurface.content
variables are different, updates to the following component theme files will need to be updated if the component is being used in the existing app:base
base
base
base
base
colors.primary
colors.secondary
colors.error
base
colors.default.text
colors.primary.filled
colors.secondary.filled
colors.success.filled
colors.warning.filled
colors.error.filled
dot
base
base
adornment.base
tooltip
groupItem.title
base
base
header
base
arrow
node.base
node.button.icon
Other information
Not affecting Reablocks theme, but
surface.disabled
was also removed and the story using the token was updated accordingly for both light and dark theme.Figma plugin updates here
Migration notes will be updated as part of the reablocks website PR.