Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drawer custom animation props #262

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Oct 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

This adds the ability to pass MotionProps to the Drawer component to customize it's animation

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screen.Recording.2024-10-23.at.4.47.29.PM.mov

@ghsteff ghsteff requested a review from amcdnl October 23, 2024 21:48
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 2d66edc
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/67196f425b23470008025c7a
😎 Deploy Preview https://deploy-preview-262--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@steppy452 steppy452 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amcdnl amcdnl merged commit 9d528d4 into master Oct 24, 2024
5 checks passed
@amcdnl amcdnl deleted the feat/Add-drawer-custom-animation branch October 24, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants