Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial state for checkbox #265

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

SerhiiTsybulskyi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Checkbox disappears after re-render on prod build when StrictMode is disabled

Issue Number: N/A

What is the new behavior?

Checkbox has initial state so always apply that state, checking animation is still works

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Screen.Recording.2024-10-31.at.11.07.26.mov

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit d9d6762
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/67234a3d9bdd3300083cd27c
😎 Deploy Preview https://deploy-preview-265--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SerhiiTsybulskyi SerhiiTsybulskyi merged commit e5abc8f into master Oct 31, 2024
5 checks passed
@SerhiiTsybulskyi SerhiiTsybulskyi deleted the checkbox-initial-state branch October 31, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants