Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disable select option and add story #266

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

Setting a specific select option to be disabled was not actually disabling the option

What is the new behavior?

  • Option is disabled
  • New storybook story has been added for the use case
Screen.Recording.2024-11-02.at.2.14.46.AM.mov

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@steppy452 steppy452 requested a review from amcdnl November 1, 2024 18:19
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for reablocks-storybook ready!

Name Link
🔨 Latest commit 4d82809
🔍 Latest deploy log https://app.netlify.com/sites/reablocks-storybook/deploys/67251b99cc5d490008ee3293
😎 Deploy Preview https://deploy-preview-266--reablocks-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit 8f42cc9 into master Nov 1, 2024
5 checks passed
@amcdnl amcdnl deleted the bug/select-disabled-option branch November 1, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants