Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard navigation improvements to select component #89

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

steppy452
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • Using tab on an "active" select option doesn't select the option, it just moves to the next input
  • I found a bug with Creatable selection using Enter key
Screen.Recording.2023-12-14.at.11.22.40.AM.mov

Issue Number: N/A

What is the new behavior?

  • Added a TabToSelect option to allow for selection on an active option using the Tab key
Screen.Recording.2023-12-14.at.11.42.52.AM.mov
  • Fixed bug w/ Creatable selection using Enter key
  • Other minor keyboard navigation improvements:
    • If a user starts to type and filter down options, automatically select the first option to easily select and move on without having to down arrow
    • For multiple selections, keep the menu open where the user was currently active for easier selection of another option. The exception is if a keyword was used to find the option
Screen.Recording.2023-12-14.at.11.30.54.AM.mov

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@steppy452 steppy452 requested a review from amcdnl December 14, 2023 17:44
@amcdnl amcdnl merged commit 8584574 into master Dec 14, 2023
1 check passed
@amcdnl amcdnl deleted the syang/select-keyboard-improvements branch December 14, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants