Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more radio css variables #94

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Jan 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Limited radio styling customizability

What is the new behavior?

More radio customizability

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

example usage of new variables

Screen.Recording.2024-01-03.at.4.14.06.PM.mov

@ghsteff ghsteff requested a review from amcdnl January 3, 2024 21:32
@@ -43,8 +44,8 @@
height: 14px;

.indicator {
width: 6px;
height: 6px;
width: var(--radio-indicator-size);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's default these to the old ones here

@amcdnl amcdnl merged commit b4a04f3 into master Jan 4, 2024
1 check passed
@amcdnl amcdnl deleted the Add-more-radio-css-variables branch January 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants