fixed library list rendering way in a single map func using absolute pos #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochanje210
commented
Jan 18, 2017
| for (let i = 0; i < this.state.dataSource.length; i = i + 1) { | ||
| this.state.initialBookColor.push(generateRandomColor()); | ||
| } | ||
| this.panResponder = PanResponder.create({ |
There was a problem hiding this comment.
this panresponder is not being used. I will either delete this or update it to use it
ochanje210
commented
Jan 18, 2017
| }; | ||
|
|
||
| shouldComponentUpdate(nextState) { |
There was a problem hiding this comment.
this is in order to optimize performance. Here is the ref FYI: https://facebook.github.io/react/docs/optimizing-performance.html#shouldcomponentupdate-in-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am changing the way of rendering library list from two columns using two arrays to single one. This change will make having dynamic sorting animation easier. Currently, drag&drop func is not implemented here yet. Since this is experimental, you don't have to consider this as high priority.