Adding support for General Ledger Accounts #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8eth
force-pushed
the
add-general-ledger-accounts
branch
from
475b575 to
ee661f9
Compare
faiberrec
reviewed
Jan 26, 2024
tests/test_resources.py
Outdated
Comment on lines
3396
to
3403
| def test_list_general_ledger_accounts(self): | ||
| with self.mock_request('general_ledger_accounts/list.xml'): | ||
| general_ledger_accounts = GeneralLedgerAccount.all()[0] | ||
|
|
||
| self.assertEqual(general_ledger_accounts.id, 'u90r5deeaxix') | ||
| self.assertEqual(general_ledger_accounts.code, 'code1') | ||
| self.assertEqual(general_ledger_accounts.account_type, 'revenue') | ||
| self.assertEqual(general_ledger_accounts.description, 'Some Description') |
There was a problem hiding this comment.
I think for an index endpoint, we want to test if we got many objects in return, also would be nice to have a test using the filter by account_type.
There was a problem hiding this comment.
updated test to check for count instead 👍
Smolations
approved these changes
Jan 26, 2024
8eth
force-pushed
the
add-general-ledger-accounts
branch
from
e32e454 to
544b0eb
Compare
faiberrec
approved these changes
Jan 26, 2024
recurly-integrations
pushed a commit
that referenced
this pull request
Mar 13, 2024
[Full Changelog](2.10.10...2.10.11) **Merged Pull Requests** - Adding RevRec Support for Purchases [#680](#680) ([8eth](https://github.com/8eth)) - Adding RevRec Support for Add Ons [#679](#679) ([8eth](https://github.com/8eth)) - Adding RevRec Support for Gift Cards and Items [#676](#676) ([8eth](https://github.com/8eth)) - Adding RevRec Support for Shipping Methods [#675](#675) ([8eth](https://github.com/8eth)) - Adding RevRec Support for Plans [#673](#673) ([8eth](https://github.com/8eth)) - Adding RevRec Support for Business Entities [#672](#672) ([8eth](https://github.com/8eth)) - Adding support for Performance Obligations [#671](#671) ([8eth](https://github.com/8eth)) - [DO NOT MERGE] Add RevRec Features to Python [#670](#670) ([8eth](https://github.com/8eth)) - Adding support for General Ledger Accounts [#667](#667) ([8eth](https://github.com/8eth))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates the
GeneralLedgerAccountentity for the V2 client, the primary entity concerning the new (and upcoming) RevRec API features.