Fixed multiple close problem. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redboltz
force-pushed
the
make_spize_ep
branch
3 times, most recently
from
95c3598 to
b40629f
Compare
close async function is called not only by user but also internally. Their CompletionToken should be invoked validly. In order to do that, the mechanism to extend endpoint lifetime is required. So I made endpoint shared_ptr based design and using shared_from_this().
redboltz
force-pushed
the
make_spize_ep
branch
from
b40629f to
b59627e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close async function is called not only by user but also internally. Their CompletionToken should be invoked validly. In order to do that, the mechanism to extend endpoint lifetime is required. So I made endpoint shared_ptr based design and using shared_from_this().