Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sansio3 #375

Closed
wants to merge 32 commits into from
Closed

Sansio3 #375

wants to merge 32 commits into from

Conversation

redboltz
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 93.03005% with 167 lines in your changes missing coverage. Please review.

Project coverage is 96.11%. Comparing base (5243283) to head (9cb009c).

Files with missing lines Patch % Lines
...clude/async_mqtt/protocol/impl/connection_impl.ipp 94.79% 48 Missing ⚠️
include/async_mqtt/impl/endpoint_misc.ipp 86.13% 47 Missing ⚠️
include/async_mqtt/protocol/impl/timer_impl.ipp 0.00% 20 Missing ⚠️
...clude/async_mqtt/protocol/impl/connection_send.hpp 94.58% 19 Missing ⚠️
include/async_mqtt/impl/endpoint_send.hpp 89.13% 10 Missing ⚠️
include/async_mqtt/impl/endpoint_recv.hpp 95.48% 6 Missing ⚠️
...t/predefined_layer/customized_websocket_stream.hpp 93.93% 4 Missing ⚠️
..._mqtt/predefined_layer/customized_basic_stream.hpp 94.33% 3 Missing ⚠️
...nc_mqtt/predefined_layer/customized_ssl_stream.hpp 93.87% 3 Missing ⚠️
...ude/async_mqtt/impl/endpoint_release_packet_id.hpp 80.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   97.34%   96.11%   -1.23%     
==========================================
  Files         154      163       +9     
  Lines        9474    10046     +572     
==========================================
+ Hits         9222     9656     +434     
- Misses        252      390     +138     
Files with missing lines Coverage Δ
include/async_mqtt/client.hpp 100.00% <ø> (ø)
include/async_mqtt/detail/stream_layer.hpp 100.00% <100.00%> (ø)
...sync_mqtt/impl/client_acquire_unique_packet_id.hpp 100.00% <ø> (ø)
...mpl/client_acquire_unique_packet_id_wait_until.hpp 100.00% <ø> (ø)
include/async_mqtt/impl/client_auth.hpp 100.00% <100.00%> (ø)
include/async_mqtt/impl/client_close.hpp 100.00% <ø> (ø)
include/async_mqtt/impl/client_disconnect.hpp 98.38% <100.00%> (ø)
include/async_mqtt/impl/client_impl.hpp 100.00% <100.00%> (ø)
include/async_mqtt/impl/client_misc.hpp 100.00% <100.00%> (ø)
include/async_mqtt/impl/client_misc.ipp 100.00% <100.00%> (ø)
... and 138 more

... and 1 file with indirect coverage changes

For PUBLISH QoS2 packet receiving after PUBREC is sent.
@redboltz redboltz marked this pull request as ready for review December 6, 2024 10:37
@redboltz redboltz closed this Dec 6, 2024
@redboltz redboltz deleted the sansio3 branch December 6, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants