Added workaround for async_shutdown(). #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 89.15% 89.02% -0.14%
==========================================
Files 92 92
Lines 10088 10130 +42
==========================================
+ Hits 8994 9018 +24
- Misses 1094 1112 +18
|
When counterpart socket closed immediately, TLS async_shutdown() CompletionToken never called. It very rarely happened. This fix added timeout for that. If timer is fired, then TCP layer closed forcibly.
redboltz
force-pushed
the
fix_tls_shutdown_unfiniiish
branch
from
656dbb2 to
d1ea787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When counterpart socket closed immediately, TLS async_shutdown() CompletionToken never called. It very rarely happened. This fix added timeout for that.
If timer is fired, then TCP layer closed forcibly.