[Major] Release 5.0.0 (#48)

* [Major] Release 5.0.0 Signed-off-by: rohitthakur2590 <[email protected]> * [Major] Release 5.0.0 Signed-off-by: rohitthakur2590 <[email protected]> * [Major] Release 5.0.0 Signed-off-by: rohitthakur2590 <[email protected]> * fix lint jobs Signed-off-by: rohitthakur2590 <[email protected]> * Fix lint issues Signed-off-by: rohitthakur2590 <[email protected]> --------- Signed-off-by: rohitthakur2590 <[email protected]>
redhat-cop · Dec 1, 2023 · b4f4cfe · b4f4cfe
1 parent b579fc9
commit b4f4cfe
Show file tree

Hide file tree

Showing 9 changed files with 78 additions and 40 deletions.
diff --git a/.ansible-lint b/.ansible-lint
@@ -0,0 +1,8 @@
+---
+profile: production
+
+exclude_paths:
+  - changelogs/changelog.yaml
+skip_list:
+  # this rule error out correct vars names for network validated content.
+  - var-naming[no-role-prefix]
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -0,0 +1,13 @@
+---
+name: ansible-lint
+on:  # yamllint disable-line rule:truthy
+  pull_request:
+    branches: ["main"]
+jobs:
+  build:
+    name: Ansible Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run ansible-lint
+        uses: ansible/ansible-lint@main
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -13,8 +13,6 @@ on:  # yamllint disable-line rule:truthy
     - cron: '0 0 * * *'
 
 jobs:
-  ansible-lint:
-    uses: ansible-network/github_actions/.github/workflows/ansible-lint.yml@main
   changelog:
     uses: ansible-network/github_actions/.github/workflows/changelog.yml@main
     if: github.event_name == 'pull_request'
@@ -94,17 +92,13 @@ jobs:
   all_green:
     if: ${{ always() && (github.event_name != 'schedule') }}
     needs:
-      - ansible-lint
       - changelog
       - sanity
     runs-on: ubuntu-latest
     steps:
-      - run: >-
-          steps:
       - run: >-
           python -c "assert 'failure' not in
           set([
-          '${{ needs.ansible-lint.result }}',
           '${{ needs.changelog.result }}',
           '${{ needs.sanity.result }}',
           ])"
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -5,6 +5,19 @@ Network Bgp Collection Release Notes
 .. contents:: Topics
 
 
+v5.0.0
+======
+
+Release Summary
+---------------
+
+Starting from this release, the minimum `ansible-core` version this collection requires is `2.14.0`. That last known version compatible with ansible-core<2.14 is `v4.0.0`
+
+Major Changes
+-------------
+
+- Bumping `requires_ansible` to `>=2.14.0`, since previous ansible-core versions are EoL now.
+
 v4.0.0
 ======
 

diff --git a/README.md b/README.md
@@ -10,7 +10,7 @@ The `network.bgp` enables users to manage the BGP resources independent of platf
 
 ## Tested with Ansible
 
-Tested with ansible-core 2.13 releases.
+Tested with ansible-core 2.14 releases.
 
 ## Installation
 #### Install from Automation Hub

diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml
@@ -87,3 +87,13 @@ releases:
     - fix_lint_issues.yaml
     - update_logs_and_tests.yaml
     release_date: '2023-07-25'
+  5.0.0:
+    changes:
+      major_changes:
+        - Bumping `requires_ansible` to `>=2.14.0`, since previous ansible-core versions
+          are EoL now.
+      release_summary:
+        Starting from this release, the minimum `ansible-core` version
+        this collection requires is `2.14.0`. The last known version compatible with
+        ansible-core<2.14 is `v4.0.0`.
+    release_date: '2023-12-01'
diff --git a/galaxy.yml b/galaxy.yml
@@ -2,8 +2,8 @@
 authors:
   - Rohit Thakur (rohitthakur2590)
 dependencies:
-  "ansible.netcommon": ">=5.1.1"
-  "ansible.utils": ">=2.9.0"
+  "ansible.netcommon": ">=6.0.0"
+  "ansible.utils": ">=3.0.0"
 license_file: LICENSE
 name: bgp
 description: Ansible Network BGP enables users to manage the BGP resources independently of platforms and perform BGP health checks.
@@ -12,4 +12,4 @@ readme: README.md
 repository: https://github.com/redhat-cop/network.bgp
 issues: https://github.com/redhat-cop/network.bgp/issues
 tags: [networking]
-version: 4.0.0
+version: 5.0.0
diff --git a/meta/runtime.yml b/meta/runtime.yml
@@ -1,2 +1,2 @@
 ---
-requires_ansible: ">=2.13.0"
+requires_ansible: ">=2.14.0"
diff --git a/plugins/filter/health_check_view.py b/plugins/filter/health_check_view.py
@@ -20,40 +20,40 @@
 - name: health_check
   vars:
     checks:
-    - name: all_neighbors_up
-      ignore_errors: true
-    - name: all_neighbors_down
-      ignore_errors: true
-    - name: min_neighbors_up
-      min_count: 1
-    - name: bgp_status_summary
+      - name: all_neighbors_up
+        ignore_errors: true
+      - name: all_neighbors_down
+        ignore_errors: true
+      - name: min_neighbors_up
+        min_count: 1
+      - name: bgp_status_summary
 
 - ansible.builtin.set_fact:
     bgp_health:
       bgp_table_version: 3
       local_as: 500
       neighbors:
-      - bgp_table_version: 3
-        input_queue: 0
-        msg_rcvd: 52076
-        msg_sent: 52111
-        output_queue: 0
-        peer: 12.0.0.1
-        peer_as: 500
-        peer_state: 1
-        uptime: 4w4d
-        version: 4
-
-      - bgp_table_version: 1
-        input_queue: 0
-        msg_rcvd: 0
-        msg_sent: 0
-        output_queue: 0
-        peer: "23.0.0.1"
-        peer_as: 500,
-        peer_state: "Idle"
-        uptime: "never"
-        version: 4
+        - bgp_table_version: 3
+          input_queue: 0
+          msg_rcvd: 52076
+          msg_sent: 52111
+          output_queue: 0
+          peer: 12.0.0.1
+          peer_as: 500
+          peer_state: 1
+          uptime: 4w4d
+          version: 4
+
+        - bgp_table_version: 1
+          input_queue: 0
+          msg_rcvd: 0
+          msg_sent: 0
+          output_queue: 0
+          peer: "23.0.0.1"
+          peer_as: 500,
+          peer_state: "Idle"
+          uptime: "never"
+          version: 4
       path:
         memory_usage: 288
         total_entries: 2
@@ -62,7 +62,7 @@
 
 - name: Set health checks fact
   ansible.builtin.set_fact:
-     health_checks: "{{ bgp_health | health_check_view(item) }}"
+    health_checks: "{{ bgp_health | health_check_view(item) }}"
 
 # ok: [192.168.22.43] => {
 #     "failed_when_result": false,