Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against parameters in main request_data #406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Protect against parameters in main request_data #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions imgfac/rest/RESTv2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ def create_image(image_collection, base_image_id=None, target_image_id=None):
request_data = form_data.get(image_type)
if(not request_data):
raise HTTPResponse(status=400, output='%s not found in request.' % image_type)
for rdatakey in request_data.keys():
if rdatakey not in ['base_image_id', 'target_image_id', 'template',
'parameters', 'provider', 'credentials',
'target']:
raise HTTPResponse(status=400, output='Unexpected key %s found in request, maybe put in parameters?' % rdatakey)

req_base_img_id = request_data.get('base_image_id')
req_target_img_id = request_data.get('target_image_id')
Expand Down