Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set default values for arrays 🧋 #54

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Sep 26, 2024

now [] will override the default value.

now `[]` will override the default value.
@jamacku jamacku linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 24.11%. Comparing base (552dc0d) to head (d06efc1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/config.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   24.43%   24.11%   -0.32%     
==========================================
  Files          13       13              
  Lines         528      535       +7     
  Branches       17       17              
==========================================
  Hits          129      129              
- Misses        395      402       +7     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like arrayMerge is not defined? I don't follow.

src/config.ts Show resolved Hide resolved
Copy link

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. it is used by deepmerge https://www.npmjs.com/package/deepmerge

@jamacku jamacku merged commit b9439b6 into redhat-plumbers-in-action:main Sep 26, 2024
5 of 7 checks passed
@jamacku jamacku deleted the fix-default branch September 26, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'target_branch' in case empty MUST NOT merge.
2 participants