fix: Correctly identify latest tag in repository

redhat-plumbers-in-action · Nov 3, 2022 · d44e67d · d44e67d
1 parent 9d463a3
commit d44e67d
Show file tree

Hide file tree

Showing 9 changed files with 55 additions and 38 deletions.
diff --git a/dist/app.js b/dist/app.js
diff --git a/dist/app.js.map b/dist/app.js.map
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/dist/tag.d.ts b/dist/tag.d.ts
diff --git a/dist/tag.js b/dist/tag.js
diff --git a/dist/tag.js.map b/dist/tag.js.map
diff --git a/src/app.ts b/src/app.ts
@@ -23,7 +23,7 @@ const app = (probot: Probot) => {
         return;
       }
 
-      const tag = new Tag(await Tag.getLatestTag(context));
+      const tag = new Tag(await Tag.getLatestTag());
 
       if (!tag.latest) {
         warning(`Repository doesn't have any tags or releases published.`);

diff --git a/src/tag.ts b/src/tag.ts
@@ -1,6 +1,9 @@
-import { Context } from 'probot';
+import { exec } from 'node:child_process';
+import { promisify } from 'node:util';
 
-import { events } from './events';
+import { warning } from '@actions/core';
+
+const promiseExec = promisify(exec);
 
 export class Tag {
   private _latest: string | undefined;
@@ -21,16 +24,18 @@ export class Tag {
     );
   }
 
-  static async getLatestTag(
-    context: {
-      [K in keyof typeof events]: Context<typeof events[K][number]>;
-    }[keyof typeof events]
-  ) {
-    const tags = (await context.octokit.rest.repos.listTags(context.repo()))
-      .data;
+  static async getLatestTag() {
+    // Get latest tag sorted by date, currently impossible by using GitHub REST API
+    // Based on: https://gist.github.com/rponte/fdc0724dd984088606b0?permalink_comment_id=3475480#gistcomment-3475480
+    const { stdout, stderr } = await promiseExec(
+      'git tag --sort=committerdate | tail -1'
+    );
 
-    if (!tags || tags.length <= 0) return undefined;
+    const tag = stdout;
+    if (stderr) {
+      warning(`Unable to get latest tag - stderr: ${stderr}`);
+    }
 
-    return tags.shift()?.name;
+    return !tag || tag.length <= 0 ? undefined : tag;
   }
 }