Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to use codeql-action/upload-sarif action for SARIF upload :octocat: #100

Closed
jamacku opened this issue Sep 1, 2022 · 1 comment · Fixed by #110
Closed

Allow users to use codeql-action/upload-sarif action for SARIF upload :octocat: #100

jamacku opened this issue Sep 1, 2022 · 1 comment · Fixed by #110
Assignees
Labels

Comments

@jamacku
Copy link
Member

jamacku commented Sep 1, 2022

Type of issue

Feature Request

Description

Let's try one more time to use codeql-action/upload-sarif action for uploading SARIF to GitHub.

From what I saw in other actions, it should also work for forks.

Describe the solution you'd like

codeql-action/upload-sarif: https://github.com/github/codeql-action/tree/main/upload-sarif
actions/upload-artifact: https://github.com/actions/upload-artifact
docs: https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github
example: https://github.com/mattermost/mattermost-server/blob/master/.github/workflows/scorecards-analysis.yml

@jamacku jamacku self-assigned this Sep 1, 2022
@jamacku jamacku added the type: feature New feature label Sep 1, 2022
@jamacku jamacku linked a pull request Sep 7, 2022 that will close this issue
3 tasks
@jamacku jamacku moved this to In Progress in Differential ShellCheck Jan 8, 2023
@jamacku jamacku changed the title Let's try to use codeql-action/upload-sarif action for SARIF upload :octocat: Allow users to use codeql-action/upload-sarif action for SARIF upload :octocat: Jan 15, 2023
@jamacku
Copy link
Member Author

jamacku commented Jan 15, 2023

To maintain backward compatibility, we will be using the current solution for SARIF uploads, but we will allow users to opt-out and use other solutions (e.g. github/codeql-action/upload-sarif GitHub Action)

@github-project-automation github-project-automation bot moved this from In Progress to Released in Differential ShellCheck Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

1 participant