Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SARIF results as output for further use 📦 #110

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Sep 7, 2022

  • Use github/codeql-action/upload-sarif for SARIF uploads
  • Documentation
  • CHANGELOG

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #110 (f193c9a) into main (efc9edd) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

❗ Current head f193c9a differs from pull request most recent head 2c31db9. Consider uploading reports for the commit 2c31db9 to get more accurate results

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   71.42%   70.83%   -0.60%     
==========================================
  Files           4        4              
  Lines         238      240       +2     
==========================================
  Hits          170      170              
- Misses         68       70       +2     
Impacted Files Coverage Δ
src/index.sh 63.26% <0.00%> (-2.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jamacku jamacku force-pushed the codeql-action branch 3 times, most recently from 5831d15 to b4e789f Compare September 7, 2022 13:03
@jamacku jamacku linked an issue Sep 7, 2022 that may be closed by this pull request
@jamacku
Copy link
Member Author

jamacku commented Sep 7, 2022

@jamacku jamacku force-pushed the codeql-action branch 6 times, most recently from 8e2da11 to be0a960 Compare September 12, 2022 08:44
@jamacku jamacku force-pushed the codeql-action branch 2 times, most recently from 635fb86 to d56bd2d Compare January 14, 2023 12:39
@mergify mergify bot added the source label Jan 14, 2023
@jamacku jamacku force-pushed the codeql-action branch 6 times, most recently from 376c427 to b8c3fee Compare January 14, 2023 20:07
--set-scan-prop='tool-url:https://www.shellcheck.net/wiki/' \
'../sarif-defects.log' >> output.sarif

echo "sarif=output.sarif" >> "${GITHUB_OUTPUT}"

Check warning

Code scanning / shellcheck

GITHUB_OUTPUT is referenced but not assigned.

GITHUB_OUTPUT is referenced but not assigned.
@jamacku jamacku changed the title WIP: Use github/codeql-action/upload-sarif Expose SARIF results as output for further use 📦 Jan 14, 2023
@jamacku jamacku marked this pull request as ready for review January 15, 2023 10:19
SARIF data are available under output `sarif`.

Co-authored-by: Kamil Dudka <[email protected]>
@jamacku jamacku merged commit fde74a1 into redhat-plumbers-in-action:main Jan 15, 2023
@jamacku jamacku deleted the codeql-action branch January 15, 2023 10:30
@jamacku jamacku linked an issue Jan 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To be Released
1 participant