169 Broken breadcrumb in OpenShift docs #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vikram-redhat, this fixes the breadcrumb issue in some pages where it links to the wrong parent. |
|
Sorry, just seeing these. @gabriel-rh thanks for these. I don't have the bandwidth to test this. I am hoping you and others can test it to make sure it works? If yes, then go ahead and merge and then I can do a release along with the other fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses #169
There is an accompanying change required in the templates in the OpenShift docs repo.
This is a brute force fix, specifically for OpenShift docs, as they do not use the breadcrumb templating code in asciibinder that was added to address arbitrary levels of breadcrumbs.