Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): update cesium #951

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat(web): update cesium #951

merged 5 commits into from
Apr 9, 2024

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Apr 4, 2024 •
edited
Loading

Overview

I updated Cesium to use latest version of Cesium.

There are a lot of update.

  • Some API like Model, 3DTiles, Terrain and ImageryLayer is loaded asynchronously.
  • Rendering process seems to be changed a bit. We need to invoke requestRender in additional part in beta.

What I've done

  • Updated the code of classic, classic's NLS and beta.

What I haven't done

How I tested

  • Build this PR of resium.
  • Replace reearth/web/node_modules/resium/dist by the generated dist directory of resium.
  • Run yarn start.
  • Test classic, classic's NLS(This might be unnecessary?) and beta(include VIEW3) entirely.

Which point I want you to review particularly

Memo

@keiya01 keiya01 requested a review from KaWaite April 4, 2024 06:57
@keiya01 keiya01 self-assigned this Apr 4, 2024
@github-actions github-actions bot added the web label Apr 4, 2024
@github-actions github-actions bot requested a review from pyshx April 4, 2024 06:57
@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

❌ Deploy Preview for reearth-web failed.

Name Link
🔨 Latest commit f36f321
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6614d8ce8a043100088a4f42

@keiya01 keiya01 merged commit b77f586 into main Apr 9, 2024
8 of 12 checks passed
@keiya01 keiya01 deleted the update/cesium branch April 9, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaWaite KaWaite KaWaite left review comments

@mkumbobeaty mkumbobeaty mkumbobeaty approved these changes

@airslice airslice airslice approved these changes

@pyshx pyshx Awaiting requested review from pyshx

Assignees

@keiya01 keiya01

Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keiya01 @mkumbobeaty @airslice @KaWaite