Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check in newSubscriberCoincidenceInner whether occRef is already set #496

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Reflex/Spider/Internal.hs
Original file line number Diff line number Diff line change
Expand Up @@ -535,10 +535,12 @@ newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoinciden
newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
{ subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
#ifdef DEBUG
occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
case occ of
Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
Just _ -> error "Coincidence inner is propagating, but coincidence occurrence is already known?"
Nothing -> do
#endif
liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
scheduleClear $ coincidenceSubscribedOccurrence subscribed
propagate a $ coincidenceSubscribedSubscribers subscribed
Expand Down
Loading