Feature/newsletter #158
Open
Feature/newsletter #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-local email validation. -show a message on registration. on the backend: -reject duplicated emails
|
@leosa83 can you please check this crazy good PR? |
|
Will check it out during the day. |
leosa83
reviewed
Oct 5, 2016
| Christian Landgren </li><li> | ||
| David Tobar Herrera </li><li> | ||
| Elhabib Moustaid </li><li> | ||
| Jamil Walli </li><li> | ||
| Leo Salmonsson </li><li> | ||
| Leop Salmonsson </li><li> |
There was a problem hiding this comment.
Leo Salmonsson not "Leop Salmonsson"
leosa83
reviewed
Oct 5, 2016
| @@ -75,13 +75,20 @@ | |||
| downv.get({id: projectId}) | |||
| } | |||
|
|
|||
| //for newsletter | |||
| var newsletter = $resource('https://refugeetech-projecthub-cms.meteorapp.com/api/v02/newsletter/:email', {email: '@email'}) | |||
There was a problem hiding this comment.
Will need to implement and try this out with the backend before merging.
|
Please resolve all conflicts. |
|
@serabile @superyass please check :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.