media-object-refinement #197
Conversation
| @@ -354,21 +302,17 @@ exports[`CdrMediaObject > snapshot tests > media width dynamic 1`] = ` | |||
| exports[`CdrMediaObject > snapshot tests > overlay, row align, column align, content configured independently to 50% width 1`] = ` | |||
| <div | |||
| class="cdr-layout cdr-layout--rows cdr-layout--columns cdr-media-object cdr-media-object--overlay" | |||
| style="--cdr-layout-rows: auto; --cdr-layout-columns: auto; --cdr-media-object-row-align: center; --cdr-media-object-column-align: end;" | |||
| style="--cdr-layout-rows: 56cqw; --cdr-layout-columns: auto; --cdr-media-object-row-align: center; --cdr-media-object-column-align: end;" | |||
There was a problem hiding this comment.
Did you test this on Firefox? https://caniuse.com/mdn-api_css_cqw_static
There was a problem hiding this comment.
I think this is the link of importance:
https://caniuse.com/mdn-css_types_length_container_query_length_units
With that said, you do bring up a good point about browser support. If we look at the updated browser matrix:
https://rei-coop.atlassian.net/wiki/spaces/FED/pages/229213181/REI+Supported+Browser+Matrix
It looks like iOS safari still does not support container queries (it is supported on v16). I think we should have a chat about all this.
There was a problem hiding this comment.
My bad, you are right! And we should introduce a polyfill for now. Thoughts @mhewson?
There was a problem hiding this comment.
Something like this? https://github.com/GoogleChromeLabs/container-query-polyfill
Sounds helpful
There was a problem hiding this comment.
Yes, that one should be enough for polyfilling iOS 15
Description
container-type: inline-size;appliedcontainerNamepropdisplay: blockcontainer-type: inline-size;applied for fluid content compatibilityhttps://rei.github.io/rei-cedar/