BWRedits #9
Open
BWRedits #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stment removed all rows
…d associated pytest
elray1
requested changes
Jan 14, 2025
There was a problem hiding this comment.
98% of my comments here are really minor/picky things, basically just formatting. I had one actual question about whether we want to be doing a reduce_all on y vectors that's the same as what we do for x. x has an extra dimension for features, but y doesn't.
For the minor things, one thing to point out is that there is a tool called ruff that can be helpful for identifying and automatically fixing these things. See the information on installing and using ruff here: https://github.com/astral-sh/ruff?tab=readme-ov-file#getting-started
There was a problem hiding this comment.
Let's remove this file from this PR since there's not really anything here yet.
Co-authored-by: Evan Ray <[email protected]>
Co-authored-by: Evan Ray <[email protected]>
Co-authored-by: Evan Ray <[email protected]>
Co-authored-by: Evan Ray <[email protected]>
Co-authored-by: Evan Ray <[email protected]>
Co-authored-by: Evan Ray <[email protected]>
Co-authored-by: Evan Ray <[email protected]>
Co-authored-by: Evan Ray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines some edits on 2 fronts:
Reorganizing the repo and switching to uv based virtual enviornment/dependency management.
Adding in some data_processing functions with the goal of allowing for unbalanced blocks (due to missing data, multiple data sources having different data availability, etc.), and for chunking up the diffs calculation for the kernel density estimator.