Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert badge-setter and html-generator to JavaScript #59

Merged
merged 16 commits into from
Jan 22, 2025

Conversation

devin-ai-integration[bot]
Copy link

Converts badge-setter and html-generator modules to JavaScript while maintaining type safety through JSDoc comments.

Changes:

  • Convert badge-setter.ts to JavaScript with JSDoc type annotations
  • Convert html-generator.ts to JavaScript with JSDoc type annotations
  • Convert corresponding test files to JavaScript
  • Keep TypeScript files for type checking
  • Update imports to use .js extensions

This PR takes a more focused approach by converting only these two modules rather than attempting to convert the entire codebase at once.

Link to Devin run: https://app.devin.ai/sessions/a83e01409c6e47d6b64638ea726c428e

Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coorasse
Copy link
Member

This PR needs to be rebased as well

Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the PR

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1737468209-convert-badge-and-html-to-js branch from 64eabf8 to fe7546a Compare January 22, 2025 10:10
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove jsdocs comments

Comment on lines 1 to 4
/**
* @typedef {import('../static/types').PullRequestRecord} PullRequestRecord
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use jsdoc. remove them everywhere. remember this

devin-ai-integration bot and others added 13 commits January 22, 2025 10:22
Copy link
Author

Devin is currently unreachable - the session may have died.

@coorasse coorasse merged commit 24c341a into feature/v2 Jan 22, 2025
1 of 2 checks passed
@coorasse coorasse deleted the devin/1737468209-convert-badge-and-html-to-js branch January 22, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant