-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert badge-setter and html-generator to JavaScript #59
Convert badge-setter and html-generator to JavaScript #59
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This PR needs to be rebased as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase the PR
64eabf8
to
fe7546a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove jsdocs comments
src/js/services/badge-setter.test.js
Outdated
/** | ||
* @typedef {import('../static/types').PullRequestRecord} PullRequestRecord | ||
*/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use jsdoc. remove them everywhere. remember this
…l-generator Co-Authored-By: [email protected] <[email protected]>
…generating HTML Co-Authored-By: [email protected] <[email protected]>
Devin is currently unreachable - the session may have died. |
Converts badge-setter and html-generator modules to JavaScript while maintaining type safety through JSDoc comments.
Changes:
This PR takes a more focused approach by converting only these two modules rather than attempting to convert the entire codebase at once.
Link to Devin run: https://app.devin.ai/sessions/a83e01409c6e47d6b64638ea726c428e