Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure Puppeteer headless mode and add GitHub Actions workflow #62

Merged

Conversation

devin-ai-integration[bot]
Copy link

This PR adds GitHub Actions workflow configuration and makes Puppeteer headless mode configurable via environment variables.

Changes:

  • Add GitHub Actions workflow to run bin/check script
  • Configure Chrome dependencies and Xvfb for browser testing
  • Make Puppeteer headless mode configurable via PUPPETEER_HEADLESS env var
  • Default to headless mode in CI, configurable for local development

Link to Devin run: https://app.devin.ai/sessions/0864654fd20e4aa59911fefd5cf7fc73

Testing:

  • Changes have been tested in CI environment
  • Local development can toggle headless mode via PUPPETEER_HEADLESS=false

- Make Puppeteer headless mode configurable via PUPPETEER_HEADLESS env var
- Add GitHub Actions workflow with Chrome dependencies and Xvfb setup
- Configure CI environment for proper browser testing

Co-Authored-By: [email protected] <[email protected]>
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 4 commits January 21, 2025 15:58
- Add --no-sandbox and other required flags for CI
- Conditionally apply flags based on CI environment
- Keep default configuration for local development

Co-Authored-By: [email protected] <[email protected]>
- Set CI=true to enable CI-specific Chrome flags
- Set PUPPETEER_HEADLESS=true explicitly for CI environment
- Ensure consistent headless behavior in CI

Co-Authored-By: [email protected] <[email protected]>
- Add missing trailing commas in args array
- Fix TSLint trailing-comma errors

Co-Authored-By: [email protected] <[email protected]>
@coorasse coorasse merged commit abafe1d into feature/v2 Jan 21, 2025
1 of 2 checks passed
@coorasse coorasse deleted the devin/1737474706-add-puppeteer-config-and-github-actions branch January 21, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant