Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return vs throw #73

Closed
wants to merge 1 commit into from
Closed

Conversation

yaacovCR
Copy link

@yaacovCR yaacovCR commented Nov 8, 2021

Related #72

This is just a short demo showing the difference between return vs throw that causes throw to hang with even simple repeaters when a pending push has not been reached, having nothing actually to do with mapping async iterators/generators/etc.

@brainkim

I assume this is per spec, and the tests in graphql-js make optimistic? unfair? non-generator-like? assumptions.

@IvanGoncharov

@yaacovCR
Copy link
Author

yaacovCR commented Nov 8, 2021

And by per spec, I mean in line with async generators. Graphql JS now returns iterators that conform to the generator type signature, perhaps they should also follow their internal behavior.

closing, as nothing actionable

@yaacovCR yaacovCR closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant