Upgrade EC managers #5099
Merged
Upgrade EC managers #5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
requested changes
Jan 16, 2025
pkg/plan/manager.go
Outdated
Comment on lines
113
to
115
| logger.Infof("EC manager on node %s is connected but is running version %s not %s. Waiting...", nodeName, m.Version, version) | ||
| } else { | ||
| logger.Infof("EC manager on node %s is not connected. Waiting...", nodeName) |
There was a problem hiding this comment.
these logs feel like they will be too noisy at info level. typically anything that is polling in my opinion should be debug.
emosbaugh
previously approved these changes
Jan 17, 2025
emosbaugh
previously approved these changes
Jan 21, 2025
emosbaugh
previously approved these changes
Jan 21, 2025
emosbaugh
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade all EC managers as part of the 2.0 EC upgrade process
Which issue(s) this PR fixes:
SC-117404
Does this PR require a test?
Yes
Does this PR require a release note?
Does this PR require documentation?
NONE