Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote the image name in image check failure errors to make it clear it is empty #5122

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

laverya
Copy link
Member

@laverya laverya commented Jan 28, 2025

What this PR does / why we need it:

Error: failed to validate installation: failed to create online app: failed to pull: failed to write common midstream: failed to update installation images: failed to wait for image checks: failed to check if image  is private: failed to parse docker ref "": invalid reference format

is unclear

Error: failed to validate installation: failed to create online app: failed to pull: failed to write common midstream: failed to update installation images: failed to wait for image checks: failed to check if image "" is private: failed to parse docker ref "": invalid reference format

is a little more clear

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

@laverya laverya merged commit 1ad96df into main Jan 29, 2025
127 checks passed
@laverya laverya deleted the laverya/quote-image-check-failure-error branch January 29, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants