Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated download subcommand #185

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

hedge-sparrow
Copy link
Member

sbctl serve and sbctl shell don't work well with host bundles. in order to simplify the workflow of working with host bundles from tickets shared via vendor portal I'm adding a download subcommand.

sbctl download <bundle url> will download the bundle to the $PWD

@hedge-sparrow hedge-sparrow force-pushed the ash/sc-112041/add-download-subcommand branch from 65dc64f to d215256 Compare September 12, 2024 14:46
@hedge-sparrow hedge-sparrow force-pushed the ash/sc-112041/add-download-subcommand branch from d215256 to edee078 Compare September 12, 2024 14:47
@hedge-sparrow hedge-sparrow marked this pull request as ready for review September 12, 2024 14:47
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one comment I added.

cli/download.go Outdated Show resolved Hide resolved
@hedge-sparrow hedge-sparrow merged commit 88d7879 into main Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants