Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Navigation 6.x #47

Merged

Conversation

vknez
Copy link
Contributor

@vknez vknez commented Sep 20, 2021

I followed https://reactnavigation.org/docs/upgrading-from-5.x, but there might be things that are not covered. However, this is enough for us to use React Navigation 6 in a not-so-small React Native (ReScript + TypeScript) app.

I upgraded package version from 5.2.0 to 6.0.0.

Closes #43

- upgraded package version from 5.2.0 to 6.0.0
@MoOx MoOx requested a review from Freddy03h September 21, 2021 11:26
@Freddy03h
Copy link
Member

Ok! I've got time to test it, and it work well, I migrated easily thank's to your work ^^
The only missing things I noted are header and headerShown params in BottomTabs screenOptions.

I think header will need a bigger refactor because Header.t is, for now, to tied to Stack, maybe if we plan to update the binding to use the new @react-navigation/elements package it can be doable. But not mandatory for now.

However it's easy to add ~headerShown: bool=? to options in BottomTabs and I think it's mandatory for anyone using nested navigators.

@vknez
Copy link
Contributor Author

vknez commented Sep 30, 2021

Thanks @Freddy03h. The fix will follow shortly.

@Freddy03h
Copy link
Member

@MoOx do you want to test it too before we merge ?

@MoOx
Copy link
Member

MoOx commented Oct 3, 2021

No time atm. Let's merge this, I trust you :)

@MoOx MoOx merged commit 9fda4ed into rescript-react-native:main Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to React Navigation 6.0
3 participants