Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP User Popout Card #192

Closed
wants to merge 5 commits into from
Closed

WIP User Popout Card #192

wants to merge 5 commits into from

Conversation

nottisa
Copy link

@nottisa nottisa commented May 9, 2023 •
edited
Loading

This is the Entire user popup card including things like description and stuff.

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended
  • These changes do not have any notable side effects on other Revolt projects

TODO

  • Finish the Popout design
    • Better text wrapping
    • Add Profile Bannner
      • Make it so that if there is no banner for it to fill with color instead of a "link broken" picture
      • Loading animation
    • Add roles field
    • Add Markdown Description
    • Add Enlarge profile button
    • Friend request/message button(s)?
    • 3 dot context menu
      • Copy User ID
      • Block user/unblock user
      • Add user to groupchat?
  • Only allow one menu at a time + close as soon as not in focus.
  • Theme the entire project using the theming stuffs

Update UserCard.tsx
afd6e67 
a little update to the user card
@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nottisa nottisa marked this pull request as draft May 11, 2023 18:50
@nottisa nottisa changed the title Update UserCard.tsx WIP User Popout Card May 12, 2023
oliviathevampire
oliviathevampire reviewed Jun 12, 2023
View reviewed changes
components/ui/components/floating/UserCard.tsx
marginBottom: '20px'
};

function getStatusColor(status: string | null | undefined) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the colors here be changed to the ones from the current theme?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was namely just place holding, I've lost intrest for now.

@insertish
Copy link
Member

PR appears stale, closing out
NB. Further work would also have to be done to adapt to M3 design system

@insertish insertish closed this Dec 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oliviathevampire oliviathevampire oliviathevampire left review comments

Assignees
No one assigned
Labels
None yet
Projects
Revolt Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nottisa @insertish @oliviathevampire