make logout from settings modal functional #241
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
closes #242 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -196,6 +197,14 @@ const Config: SettingsConfiguration<{ server: Server }> = { | |||
| { | |||
| id: "logout", | |||
There was a problem hiding this comment.
Omit id, only onClick is necessary.
| @@ -227,4 +236,5 @@ const ClientSettingsRouting: Record<string, Component> = { | |||
| sync, | |||
| native, | |||
| experiments, | |||
| logout, | |||
There was a problem hiding this comment.
Once id is omitted, this component no longer needs to be included.
| href: "/login", | ||
| onClick: () => { | ||
| const acli = getController("state"); | ||
| const cli = getController("client").getCurrentClient(); |
There was a problem hiding this comment.
client is available through context here, add const client = useClient() at the top of the function instead of using this line here.
| @@ -196,6 +197,14 @@ const Config: SettingsConfiguration<{ server: Server }> = { | |||
| { | |||
| id: "logout", | |||
| icon: <BiSolidExit size={20} color={theme!.colours.error} />, | |||
| href: "/login", | |||
| onClick: () => { | |||
| const acli = getController("state"); | |||
There was a problem hiding this comment.
This package should also have direct access to state and it can be called through state.
| onClick: () => { | ||
| const acli = getController("state"); | ||
| const cli = getController("client").getCurrentClient(); | ||
| console.log(cli); |
| const acli = getController("state"); | ||
| const cli = getController("client").getCurrentClient(); | ||
| console.log(cli); | ||
| acli.auth.removeSession(cli?.user?.id as string); |
There was a problem hiding this comment.
This will remove the session from storage but not kill the active client in the client controller, which is remedied by assigning window.location.href (since that will just kill all active sessions) but we want to avoid reloading the client.
| const cli = getController("client").getCurrentClient(); | ||
| console.log(cli); | ||
| acli.auth.removeSession(cli?.user?.id as string); | ||
| window.location.href = "/login"; |
There was a problem hiding this comment.
Should useNavigate from routing package at top of component, and then use navigate function instead of telling the browser to redirect us.
|
PR is stale, requested changes ignored, closing out for now |
Please make sure to check the following tasks before opening and submitting a PR
closes #242