Skip to content

Commit

Permalink
Merge pull request #4 from gmorel/fix/inject_guzzle_in_mailchimp_client
Browse files Browse the repository at this point in the history 
Inject Guzzle by default into MailChimpClient
  • Loading branch information
@tyx
tyx committed Sep 19, 2014
2 parents f980ca5 + bf99a65 commit b474204
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion Resources/config/mail_chimp.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,15 @@
<parameter key="rezzza.mail_chimp.connection.http.class">Rezzza\MailChimpBundle\Connection\HttpConnection</parameter>
<parameter key="rezzza.mail_chimp.connection.stub.class">Rezzza\MailChimpBundle\Connection\StubConnection</parameter>
<parameter key="rezzza.mail_chimp.client.class">Rezzza\MailChimpBundle\Api\Client</parameter>
<parameter key="rezzza.mail_chimp.http.client.class">Guzzle\Http\Client</parameter>
</parameters>

<services>
<!-- Connection "http" -->
<service id="rezzza.mail_chimp.connection.http" class="%rezzza.mail_chimp.connection.http.class%" public="false" />
<service id="rezzza.mail_chimp.connection.http" class="%rezzza.mail_chimp.connection.http.class%" public="false" >
<argument>false</argument>
<argument>rezzza.mail_chimp.http.client</argument>

This comment has been minimized.

Sign in to view

Copy link
@lmammino

lmammino Nov 10, 2014

It should be <argument type="service" id="rezzza.mail_chimp.http.client"/> 😞
How to fix this specific version?

This comment has been minimized.

Sign in to view

Copy link
@stephpy

stephpy Nov 10, 2014

Contributor

I did it here https://github.com/rezzza/MailChimpBundle/releases/tag/v2.0.1

This comment has been minimized.

Sign in to view

Copy link
@lmammino

lmammino Nov 10, 2014

Wow, fast as lighting ⚡

Does the 2.0 version bring breaking changes?

This comment has been minimized.

Sign in to view

Copy link
@stephpy

stephpy Nov 10, 2014

Contributor

Yes, semantically moving x on x.y.z (semver) introduce one/x BC break.

You can look at diffs between 1.0.4 and 2.0.1 here

We didn't create a CHANGELOG file, it's a mistake. However, any help is welcome. :)

This comment has been minimized.

Sign in to view

Copy link
@lmammino

lmammino Nov 10, 2014

@stephpy, That's what I expected, thanks for the very detailed answer.
Anyway the 1.0.x is still bugged... Can you please also create a 1.0.5 tag where you add this last fix to the 1.0.x branch? It would be a great help for those who are still using the 1.0.x branch (like me).

This comment has been minimized.

Sign in to view

Copy link
@stephpy

stephpy Nov 10, 2014

Contributor

I didn't see this commit was applied to 1.x too :\

Done here: https://github.com/rezzza/MailChimpBundle/releases/tag/v1.0.5

This comment has been minimized.

Sign in to view

Copy link
@stephpy

stephpy Nov 10, 2014

Contributor

Branch 1.0.x was created https://github.com/rezzza/MailChimpBundle/tree/1.0.x

I cannot ensure we'll maintain it a long time.

This comment has been minimized.

Sign in to view

Copy link
@lmammino

lmammino Nov 10, 2014

No problem with that, i'll add the task "switch to MailchimpBundle v2.*" in my todo list 😉
Thanks for saving me a good amount of time today with this latest tag!

This comment has been minimized.

Sign in to view

Copy link
@stephpy

stephpy Nov 12, 2014

Contributor

You're welcome. :)
</service>

<!-- Connection "stub" -->
<service id="rezzza.mail_chimp.connection.stub" class="%rezzza.mail_chimp.connection.stub.class%" public="false" />
Expand All @@ -29,5 +33,9 @@
<argument type="service" id="rezzza.mail_chimp.connection" />
</call>
</service>

<!-- Client HTTP -->
<service id="rezzza.mail_chimp.http.client" class="%rezzza.mail_chimp.http.client.class%">
</service>
</services>
</container>

0 comments on commit b474204

Please sign in to comment.