Johnnieskywalker patch 2 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just some refactor, using polymorphism making classes more readable and reuseable
Default implementation of method returns 0.0 in order to make it act the same as in @rgolubtsov original implementation
In order to allow default methods
Used few more OO feautures, extracted some methods, renamed few variables, got rid of few variables like iAdj which was never used beside changing its value, probably had some meaning in original code but it was not used for any calculations or displaying informations.
Number of evaluations which is Hooke class variable was unnecesarily changed in Rosenbrock and Woods classes. Which meant anytime somebody wanted to find minimum of new function and have information about function evaluations had to take care of it inside method calculating values of meathematical objective function now this part is moved to Hooke class which is class of Search Method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further refactoring