WIP: using new JRE capabilities of adoptium aqa-tests #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judovana
reviewed
Nov 15, 2024
| @@ -279,7 +279,7 @@ jobs: | |||
| run: echo 'export PATH="/usr/local/bin:$PATH"' >> $HOME/.zprofile && exec -l $SHELL | |||
|
|
|||
| - name: Verify Bash Version | |||
| run: /opt/homebrew/Cellar/bash/bin/bash --version | |||
| run: /opt/homebrew/Cellar/bash/5.2.37/bin/bash --version | |||
There was a problem hiding this comment.
apparently the path to the bash executable changed since the last GH actions run..
andrlos
changed the title
|
DO NOT merge until I create a related PR in the rh-openjdk internal infrastructure, projecting these changes in the aqa runner there |
|
I really do not like usage of exact version. can you elaborate more pelase?
--
Mgr. Jiri Vanek
***@***.***
---------- Původní e-mail ----------
Od: andrlos ***@***.***>
Komu: rh-openjdk/TestHeadlessComponents ***@***.***
github.com>
Kopie: judovana ***@***.***>, Comment ***@***.***>
Datum: 17. 11. 2024 19:31:35
Předmět: Re: [rh-openjdk/TestHeadlessComponents] WIP: using new JRE
capabilities of adoptium aqa-tests (PR #11)
"
@andrlos commented on this pull request.
----------------------------------------------------------------------------
In .github/workflows/test.yaml
(#11 (comment))
:
@@ -279,7 +279,7 @@ jobs:
run: echo 'export PATH="/usr/local/bin:$PATH"' >> $HOME/.zprofile && exec -l $SHELL
- name: Verify Bash Version
- run: /opt/homebrew/Cellar/bash/bin/bash --version
+ run: /opt/homebrew/Cellar/bash/5.2.37/bin/bash --version
apparently the path to the bash executable changed since the last GH actions
run..
—
Reply to this email directly, view it on GitHub
(#11 (comment))
, or unsubscribe
(https://github.com/notifications/unsubscribe-auth/AAWFCS74Y6NGKEUX7KLP4432BDOIHAVCNFSM6AAAAABRZZJD36VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINBRGEZDAMBZGM)
.
You are receiving this because you commented. Message ID: <rh-openjdk/
***@***.***>
"
|
|
@judovana this is a draft for now.. I want to first test it with our internal system.. copypasting the exact version was easier, as I was not sure whether the path will work as intended and if I am even looking in the right place.. I will get back to it, before merging - pinky promise ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using built-in adoptium management of JRE/SDK downloading, in test downloading is therefore obsolete