Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RH2117972 - Extend the support for NSS DBs (PKCS11) in FIPS mode #4

Open
wants to merge 3 commits into
base: fips
Choose a base branch
from

Conversation

martinuy
Copy link

@martinuy martinuy commented Aug 16, 2022

Search this PR in Red Hat Jira

Diff of this PR only Dependency chain
9087e80...f130489 rh-openjdk:fipsTHIS PR

11u backport of the RH2117972 enhancement. See the 17u PR for further reference: rh-openjdk/jdk#17

Differences with the 17u patch:

  • src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java

    • Hook context to add the import of import "sun.security.util.SecurityProperties".
      • Added the import manually.
  • src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Token.java

    • SharedSecrets is in the jdk.internal.misc package in 11u.
  • test/jdk/sun/security/pkcs11/fips/NssdbPin.java

    • Proc location is in test/jdk/java/security/testlibrary
    • Export of the package java.base/jdk.internal.misc to the Unnamed module is required

@martinuy martinuy marked this pull request as ready for review August 23, 2022 23:34
@martinuy martinuy requested a review from franferrax August 23, 2022 23:34
Copy link

@franferrax franferrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martinuy, it looks good to me.

NOTE: this PR already includes changes of rh-openjdk/jdk#17 review.

Copy link

@franferrax franferrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing approval, as we need to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants