Add Dockerfile #47
Open
Add Dockerfile #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #46.
The image is made to be similar to the one that's published on Docker Hub, but use best practices like a multi-stage build process to make sure the build process is containerized as well.
The Dockerfile would effortlessly support cross-platform builds if the buildx TARGET_ARCH and TARGET_OS could be used. I think that ctranslate2 is the "bottleneck", but it supports the most common archs.
Additionally, it would be nice to include a USER clause to make the container work well in a rootless scenario. But I'm not a native to Python and installing the wheel as non-root caused issues.
Lastly, ctranslate2 failed to install on newer python versions, hence, we're locked to python 3.9.