Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.8.0 #66

Merged
merged 21 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions .github/workflows/Build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,12 @@ jobs:
runs-on: windows-latest
steps:
- uses: actions/checkout@v1

- name: NuGet Setup
uses: actions/setup-dotnet@v4
with:
dotnet-version: |
7.0.x
8.0.x
- name: "NuGet Add Source Organization"
run: if ("${{ secrets.ORGANIZATION_SOURCE_PACKAGE_PASSWORD }}" -ne "") { dotnet nuget add source --username ${{ secrets.ORGANIZATION_SOURCE_PACKAGE_USERNAME }} --password ${{ secrets.ORGANIZATION_SOURCE_PACKAGE_PASSWORD }} --store-password-in-clear-text --name github "https://nuget.pkg.github.com/${{github.repository_owner}}/index.json" }

- name: Run './build/build.cmd'
run: ./build/build.cmd --root ./build
env:
GitHubToken: ${{ secrets.GITHUB_TOKEN }}
SignFile: ${{ secrets.SIGN_FILE }}
SignPassword: ${{ secrets.SIGN_PASSWORD }}
InstallationFiles: ${{ secrets.INSTALLATION_FILES }}
SignFile: ${{ secrets.SIGN_FILE_AZURE }}
SignPassword: ${{ secrets.SIGN_PASSWORD_AZURE }}
NugetApiUrl: ${{ secrets.NUGET_API_URL }}
NugetApiKey: ${{ secrets.NUGET_API_KEY }}
3 changes: 3 additions & 0 deletions Build/.nuke/build.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@
"ApplicationType": {
"type": "string"
},
"EnableForkedRepository": {
"type": "boolean"
},
"Folder": {
"type": "string"
},
Expand Down
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,29 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [1.8.0] / 2024-12-16 - 2024-12-19
### Features
- Make project public
- Fix test filter limit size `arguments` (Fix: #65)
### Application
- Remove `net46` framework, remove `Revit 2017` and `Revit 2018` support.
### Command
- Fix `AppUtils` to show `ProductName`.
- Update `ProcessStart` to show `arguments` length in debug.
- Update `RevitTestProcessStart` to create temp file for test `arguments`.
- Update `RunCommand` to read test `arguments` from temp file.
### Console
- Update `ricaun.Revit.Installation` to `1.3.1`.
- Add `EnvironmentVariable` class, with `ProcessArguments` and `TimeoutNotBusyMaxSeconds` variables.
- Remove not used `RevitAddinDisable` class.
- Update `RevitTestUtils` with `MinimalRevitVersion` to `2019`.
### Build
- Update `ci` to use public `nuget` packages.
### TestAdapter
- Update `ricaun.Security.WinTrust` to `1.1.0`.
### Tests
- Add `net47` with `Revit 2019` tests.

## [1.7.1] / 2024-12-07 - 2024-12-10
### Application
- Update to use `AssemblyMetadata` to set configuration. (Fix: #64)
Expand Down Expand Up @@ -546,6 +569,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- [x] TestsFail

[vNext]: ../../compare/1.0.0...HEAD
[1.8.0]: ../../compare/1.7.1...1.8.0
[1.7.1]: ../../compare/1.7.0...1.7.1
[1.7.0]: ../../compare/1.6.0...1.7.0
[1.6.0]: ../../compare/1.5.0...1.6.0
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project>
<PropertyGroup>
<Version>1.7.1</Version>
<Version>1.8.0</Version>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ricaun.RevitTest

[![Revit 2017](https://img.shields.io/badge/Revit-2017+-blue.svg)](https://github.com/ricaun-io/ricaun.RevitTest)
[![Revit 2019](https://img.shields.io/badge/Revit-2019+-blue.svg)](https://github.com/ricaun-io/ricaun.RevitTest)
[![Visual Studio 2022](https://img.shields.io/badge/Visual%20Studio-2022-blue)](https://github.com/ricaun-io/ricaun.RevitTest)
[![Nuke](https://img.shields.io/badge/Nuke-Build-blue)](https://nuke.build/)
[![License MIT](https://img.shields.io/badge/License-MIT-blue.svg)](LICENSE)
Expand Down
208 changes: 0 additions & 208 deletions README.old.md

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,9 @@

<!-- RevitVersion -->
<PropertyGroup>
<TargetFrameworks>net46;net47;net48;net8.0-windows</TargetFrameworks>
<TargetFrameworks>net47;net48;net8.0-windows</TargetFrameworks>
</PropertyGroup>
<Choose>
<When Condition="$(TargetFramework.StartsWith('net46'))">
<PropertyGroup>
<RevitVersion>2017</RevitVersion>
</PropertyGroup>
</When>
<When Condition="$(TargetFramework.StartsWith('net47'))">
<PropertyGroup>
<RevitVersion>2019</RevitVersion>
Expand Down
15 changes: 15 additions & 0 deletions ricaun.RevitTest.Command/Command/RunCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,21 @@ private void ValidadeOptions()
if (!File.Exists(options.File))
throw new FileNotFoundException();

// Check if first argument is a file to read the test filters (Fix: #65)
if (options.Test.Count() == 1)
{
var tempFileTestFilters = options.Test.First();
if (File.Exists(tempFileTestFilters))
{
options.Test = File.ReadAllLines(tempFileTestFilters);
try
{
File.Delete(tempFileTestFilters);
}
catch { }
}
}

Log.Enabled = options.Log;
}

Expand Down
4 changes: 2 additions & 2 deletions ricaun.RevitTest.Command/Process/ProcessStart.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ private ProcessStartInfo NewProcessStartInfo(string arguments)
public async Task Run(Action<string> consoleAction, Action<string> errorAction = null)
{
var arguments = CreateArguments();
WriteLine($"ProcessStart: {processPath}");
WriteLine($"ProcessStart.Run: {arguments}");
WriteLine($"ProcessStart[{processPath.Length}]: {processPath}");
WriteLine($"ProcessStart.Run[{arguments.Length}]: {arguments}");
await Run(arguments, consoleAction, errorAction);
}
private async Task Run(string arguments,
Expand Down
10 changes: 10 additions & 0 deletions ricaun.RevitTest.Command/Process/RevitTestProcessStart.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using ricaun.NUnit.Models;
using ricaun.RevitTest.Command.Extensions;
using System;
using System.IO;
using System.Linq;
using System.Threading.Tasks;

Expand Down Expand Up @@ -53,6 +54,15 @@ public RevitTestProcessStart SetTestFilter(string[] testFilters)
{
if (testFilters.Length == 0)
return this;

// Convert filter to file to fix the limit size of arguments (Fix: #65)
if (testFilters.Length > 32)
{
var tempFileTestFilters = Path.GetTempFileName();
File.WriteAllLines(tempFileTestFilters, testFilters);
return SetRevitArgument("test", tempFileTestFilters);
}

return SetRevitArgument("test", testFilters);
}
public RevitTestProcessStart SetTestFilter(string testFilter)
Expand Down
Loading