Skip to content

Commit

Permalink
prevent ReadAt panic
Browse files Browse the repository at this point in the history
  • Loading branch information
richardlehane committed Dec 14, 2023
1 parent 6ab5017 commit a25db5b
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions internal/siegreader/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,13 @@ import (
// The special thing about a siegreader.Reader is that you can have a bunch of them all reading independently from the one buffer.
//
// Example:
// buffers := siegreader.New()
// buffer := buffers.Get(underlying_io_reader)
// rdr := siegreader.ReaderFrom(buffer)
// second_rdr := siegreader.ReaderFrom(buffer)
// limit_rdr := siegreader.LimitedReaderFrom(buffer, 4096)
// reverse_rdr := siegreader.ReverseReaderFrom(buffer)
//
// buffers := siegreader.New()
// buffer := buffers.Get(underlying_io_reader)
// rdr := siegreader.ReaderFrom(buffer)
// second_rdr := siegreader.ReaderFrom(buffer)
// limit_rdr := siegreader.LimitedReaderFrom(buffer, 4096)
// reverse_rdr := siegreader.ReverseReaderFrom(buffer)
type Reader struct {
i int64
j int
Expand Down Expand Up @@ -105,6 +106,9 @@ func (r *Reader) Read(b []byte) (int, error) {

// ReadAt implements the io.ReaderAt interface.
func (r *Reader) ReadAt(b []byte, off int64) (int, error) {
if off < 0 {
return 0, fmt.Errorf("siegreader: ReadAt with negative value, got %v", off)
}
var slc []byte
var err error
// if b is already covered by the scratch slice
Expand Down

0 comments on commit a25db5b

Please sign in to comment.