Introduce a config option for collapsing newlines #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a config option that, when enabled, collapses leading and trailing newlines inserted while combining assets within a single file. This is necessary because, by the time this plugin runs (i.e. during the `generateBundle` stage), it is too late to perform any code minification.
|
Sorry, I'm not following why this is needed? |
|
No information provided, closing. |
|
Apologies - I didn't see your previous message. Consider the following example: package.json{
"name": "example",
"type": "module",
"version": "1.0.0",
"scripts": {
"build": "vite build",
"serve": "vite serve"
},
"devDependencies": {
"vite": "^5.0.12",
"vite-plugin-singlefile": "^1.0.0"
}
}vite.config.mjsimport { defineConfig } from "vite";
import { viteSingleFile } from "vite-plugin-singlefile";
export default defineConfig({
plugins: [
viteSingleFile({
useRecommendedBuildConfig: true,
removeViteModuleLoader: true,
}),
],
build: {
minify: true,
}
});index.html<!doctype html>
<html>
<head>
<link rel="stylesheet" crossorigin type="text/css" href="./index.css" />
</head>
<body>
Hello World!
</body>
</html>index.csshtml {
box-sizing: border-box;
text-size-adjust: none;
}The result: <!doctype html>
<html>
<head>
<style>
html{box-sizing:border-box;text-size-adjust:none}
</style>
</head>
<body>
Hello World!
</body>
</html>Notice the newlines. I would expect the following instead: <!doctype html>
<html>
<head>
<style>html{box-sizing:border-box;text-size-adjust:none}</style>
</head>
<body>
Hello World!
</body>
</html>If you're wondering why is this important for me - when on 512 Kbps, every shaven byte matters. |
|
This has been resolved in v2.0 |
|
That almost did it - see #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a config option that, when enabled, collapses leading and trailing newlines inserted while combining assets within a single file.
This is necessary because, by the time this plugin runs (i.e. during the
generateBundlestage), it is too late to perform any code minification.