Fix: use relative base path to support static resources in public folder #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static files in public folder are copied by Vite to output dir. We need output single html to correctly load them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69 . Assets in public folder are copied to ${build.outDir} by vite and not inlined by this plugin.
We CAN work with them, however, using relative path and place all resources in the same folder.
Changes of recommended build config:
config.baseto'./'to enable relative path.config.build.assetsDirto''to make generated files in ${build.outDir}'s root, instead of default ${build.outDir}/assets. Then the embedded resources can be loaded by relative path.I also updated README to inform this in
Caveats.