Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "desktop_notification" event (without contents), "member_joined_channel" and "goodbye" #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joranvar
Copy link

@joranvar joranvar commented Jul 25, 2019

Example of the contents of the event:

Object
  (fromList
    [ ("is_shared"        , Bool False)
    , ("ts"               , String "1564031630.000800")
    , ("is_channel_invite", Bool False)
    , ("channel"          , String "A1B2C3D4F")
    , ( "launchUri"
      , String
        "slack://channel?id=A1B2C3D4F&message=1564031630000800&team=5G6H7I8J9"
      )
    , ("imageUri"   , Null)
    , ("msg"        , String "1564031630.000800")
    , ("content"    , String "Test")
    , ("subtitle"   , String "joranvar")
    , ("event_ts"   , String "1564031630.000300")
    , ("title"      , String "Workspace title")
    , ("type"       , String "desktop_notification")
    , ("ssbFilename", String "knock_brush.mp3")
    , ( "avatarImage"
      , String "https://avatars.slack-edge.com/2020-12-31/someImageFile.jpg"
      )
    ]
  )

@joranvar
Copy link
Author

Just added this, so it doesn't bother me for every event :)

@mitchellwrosen
Copy link
Collaborator

Sorry, I just created a merge conflict for you. Can you rebase @joranvar?

@joranvar
Copy link
Author

No problem!

@joranvar joranvar force-pushed the add-desktop-notification-event branch from e15fdf2 to 3a0de8c Compare August 16, 2019 18:50
@joranvar joranvar changed the title Add "desktop_notification" event (without contents) Add "desktop_notification" event (without contents), "member_joined_channel" and "goodbye" Aug 16, 2019
@joranvar
Copy link
Author

Done! Should I split this into three PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants