Actionlog #16
Merged
Actionlog #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flash effect is green for healed and renewed and red for attacked. Action line for ranged attack (by towers and creeps) is now blue.
Fix a bug that caused creeps with no CARRY parts not to render. Fix a bug that prevented creep speech bubbles from showing Add attack effect
ricochet1k
requested changes
May 18, 2017
src/scripts/skins/original/creep.js
Outdated
| obj.saying = obj.actionLog.say; | ||
| } | ||
| if(obj.saying) { | ||
| say(this.g, obj.saying.message); |
There was a problem hiding this comment.
Move this into the case 'say' above, and get rid of obj.saying.
src/scripts/actions.js
Outdated
|
|
||
| g.clear(); | ||
| g.beginFill(color, v); |
There was a problem hiding this comment.
It's probably much better to set g.alpha instead of redrawing every frame
src/scripts/actions.js
Outdated
| let g = new PIXI.Graphics(); | ||
| room.g.addChild(g); | ||
|
|
||
| const color = 0xffff00; | ||
| color = color || 0xffff00; |
There was a problem hiding this comment.
This should be added as a default value to the color parameter above, like this: , color = 0xffff00) {
|
I've made the changes you suggested. (I'm new to PixiJS, thanks for catching my mistakes!) |
ricochet1k
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds most of the actions from #7. I haven't gotten around to testing all of them yet, but I will soon.