Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize nullable members for nested containers #1660

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

clegoz
Copy link
Contributor

@clegoz clegoz commented Jan 2, 2025

fix: initialize nullable members for nested containers

Description

Made changes to store IMemberAssignmentMappingContainer along with the MemberPath to keep track of nullable member initializations.

Fixes #1650

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, I added my feedback 😊

@latonz latonz added the bug Something isn't working label Jan 6, 2025
@latonz latonz merged commit d397ef2 into riok:main Jan 20, 2025
18 checks passed
@latonz
Copy link
Contributor

latonz commented Jan 20, 2025

@clegoz thanks for your contribution! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants