-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p256 acceleration #10
base: release-p256/v0.13.2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced we're tracking the identity correctly, especially in various places we make affine/projective conversions and conversions in and out of risc zero types. Can you take a look and either make fixes or help me understand how the identity is being handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, they look good!
Currently accelerates the muls and is ~8-9x speedup, but there is a lot of slop due to the unaccelerated conversion from projective to affine. Also unfortunate that this implementation has BE representation internally, so some unfortunate copies again as with k256.
TODO:
proj -> affine -> proj
Explore different bit widths acceleration(out of scope for this)Check const time signature gen (or panic on usage in zkvm)documented non const time