Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document prerequisites on Testing #1381

Merged

Conversation

a4lg
Copy link
Contributor

@a4lg a4lg commented Nov 30, 2023

pyelftools is required for a helper script.

This commit adds basic installation guide to install pyelftools and removes "automatic installation" of pyelftools from Makefile.

This is based on the counter proposal to my #1374+#1376 by @cmuellner (#1374 (comment)).

@a4lg
Copy link
Contributor Author

a4lg commented Nov 30, 2023

Note that I didn't touch .github directory because setup-apt.sh already contains installation of python3-pyelftools.

pyelftools is required for a helper script.

This commit adds basic installation guide to install pyelftools and
removes "automatic installation" of pyelftools from Makefile.
@a4lg a4lg force-pushed the document-prerequisite-when-testing branch from 507cb47 to c3bb5ca Compare November 30, 2023 05:10
@pz9115
Copy link
Contributor

pz9115 commented Nov 30, 2023

I remember that if we want to run dejagnu, we also need tcl and expect, but they are not in the prerequisite, can you also add them here, thanks.

see: https://www.gnu.org/software/dejagnu/

@a4lg a4lg changed the title Document prerequisite on Testing Document prerequisites on Testing Nov 30, 2023
@a4lg
Copy link
Contributor Author

a4lg commented Nov 30, 2023

@pz9115 I see. I think what we really need is expect alone (tcl or its libraries should be a dependency of expect) and check whether this is correct.

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this PR looks good.

Two comments:

  • RedHat/Fedora switched from yum to dnf long ago.
  • I would have put that text into the prerequisites section on top. I consider testing a fundamental feature of this repo, so all prerequisites for testing are prerequisites for this repo.

Copy link
Collaborator

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kito-cheng kito-cheng merged commit ae9efcc into riscv-collab:master Dec 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants