Update links and current statuses (batch 2022-02-20) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surely it's only the latter? |
|
kito-cheng
approved these changes
Apr 20, 2022
Comment on lines
+56
to
+58
| e.g. `-march=rv64g`. A target `-march` which includes floating point | ||
| instructions implies a hardfloat calling convention, but can be overridden | ||
| using the `-mabi` flag (see the next section). |
There was a problem hiding this comment.
Although isn't true for GNU toolchain (-march implied -mabi), but that's out of scope for this patch, and not introduced by your change, so I think that could fixed later.
There was a problem hiding this comment.
I created an issue (#20) for this.
So we can ignore that here.
luismarques
reviewed
Apr 20, 2022
README.mkd
Outdated
|
|
||
| The ISA subset naming conventions are described in Chapter 22 of the RISC-V | ||
| ISA, e.g. "rv32imafd". The abbreviation "g" can be used to represent either | ||
| `IMAFD` (when targeting RISC-V ISA specification version 2.2 or before) or |
There was a problem hiding this comment.
That would work. I'm not a native speaker so this kind of feedback is always helpful.
There was a problem hiding this comment.
I reflected your comment in the document (before → earlier). Thanks!
Expansion of "g" now depends on the target ISA version: - "IMAFD" : version 2.2 or earlier - "IMAFD_Zicsr_Zifencei" : version 20190608 or later
This commit removes an entry from "Issues for consideration" of the
"-march" section describing fine-grained architectures.
* On RISC-V ISA specification version 20190608 or later, instructions
including (but not limited to) `rdcycle` is splitted to separate
extension `Zicsr`.
* `Zmmul` extension (`M` extension with division) is frozen and being
voted for ratification.
This is because G is changed to include `Zicsr` and `Zifencei` extensions.
GNU toolchain and LLVM both support RISC-V extension version numbers. This commit reflects this fact.
a4lg
force-pushed
the
update-links-and-statuses20220220
branch
from
420134c to
5ca5b4b
Compare
cmuellner
approved these changes
May 9, 2022
There was a problem hiding this comment.
LGTM.
@kito-cheng any objections? If not, I will merge this within the next 2 days.
luismarques
approved these changes
May 9, 2022
|
@cmuellner OK to me, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for my upcoming proposals. Before proposals, we can clean this document to reflect latest statuses of GNU/LLVM toolchains and other external documents.