vcompress.vm: Check vstart value even if vl = 0 #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing vector CSRs" This reverts commit a17842c.
YenHaoChen
force-pushed
the
pr-vcompress
branch
from
a65a6c6 to
c37c96b
Compare
aswaterman
reviewed
Jan 24, 2025
YenHaoChen
force-pushed
the
pr-vcompress
branch
from
c37c96b to
3c85624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit inadvertently included an incorrect behavior: when vl=0, the instruction incorrectly failed to check if vstart!=0. (#1754 (comment))
This PR aims to achieve the same goal as #1754 while correcting this incorrect behavior.