Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove false comments from RV32 permission encoding table #386

Merged
merged 2 commits into from
Sep 30, 2024
Merged

remove false comments from RV32 permission encoding table #386

merged 2 commits into from
Sep 30, 2024

Conversation

tariqkurd-repo
Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo commented Sep 27, 2024 •
edited
Loading

quadrants 2 and 3 has a false comment copy/pasted from quadrant 0 most likely

arichardson
arichardson reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove this from quandrant 2 while there are no defined encodings where this matters.

@tariqkurd-repo tariqkurd-repo merged commit 6f36ab4 into riscv:main Sep 30, 2024
3 checks passed
tariqkurd-repo added a commit to tariqkurd-repo/riscv-cheri that referenced this pull request Oct 9, 2024
@tariqkurd-repo
Update and clarify comments from RV32 permission encoding table (risc…
f675a78 
…v#386)

No spec change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arichardson arichardson arichardson approved these changes

@andresag01 andresag01 andresag01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tariqkurd-repo @andresag01 @arichardson